Upgrading to draft-js 0.10.0 and to the new Entity API #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mdarcemont, There is a brach with initial work, but your pull request is welcome. Could you please fix the docs? In the custom entities docs: |
|
Done ! |
|
Thank you! Did you see my branch? You should fix the Entity.create() too. |
|
Sorry for missing that ! |
|
Hi @mdarcemont, thanks for contributing to Megadraft! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
draft-js 0.10.0 contains a new feature that I miss today, the ability to paste paragraphs from HTML or Word while keeping their structure.
See the pull request merged in 0.10.0 : facebookarchive/draft-js#828
So I propose the upgrading from 0.9.1 to 0.10.0. This is not a breaking change (see facebookarchive/draft-js#839 ), I've only seen warnings, that I fixed with replacing some instructions with the new API.
Entity.get(entityKey)
become
contentState.getEntity(entityKey)
Tests are ok !
I hope you'll be able to merge this soon !