Add support for Yoast canonical URL #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dinhtungdu may be worth adding a note into the readmes about the filter for others to know how to handle for this. |
dkotter
reviewed
Jun 22, 2021
includes/functions/content-sync.php
Outdated
| * | ||
| * @return {string} Canonical URL. | ||
| */ | ||
| $canonical_url = apply_filters( 'sophi_post_canonical_url', $canonical_url, $post ); |
There was a problem hiding this comment.
As discussed, I'm fine if we want to leave this filter but there's probably not a great need to have this, since there are other places this data can be filtered. If we want to remove this to simplify things, that's good with me.
dkotter
previously approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues updating the data sent to the Sophi collector. In this PR:
Relates #69 #65