Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More content schema updates #71

Merged
merged 5 commits into from
Jun 28, 2021
Merged

More content schema updates #71

merged 5 commits into from
Jun 28, 2021

Conversation

dinhtungdu
Copy link
Contributor

@dinhtungdu dinhtungdu commented Jun 25, 2021 •
edited
Loading

This PR continues the work in #70:

  • Renamed contentSize to size.
  • Updated AMP and JS tracking data to use post data type introduced in Update content sync data #65.
  • Fixed the issue with Yoast (Add support for Yoast canonical URL #70). Yoast updates the post meta after the core changes the post status. This is the reason why the canonical URL still is empty at the time we send the tracker event to Sophi. This PR ensures we only track content update events after the Yoast updating its meta.
  • Changed post data type to post content type.
  • Added documentation for post content type and canonical URL.

@dinhtungdu dinhtungdu added this to the 1.0.4 milestone Jun 25, 2021
@dinhtungdu dinhtungdu requested a review from dkotter June 25, 2021 01:57
@dinhtungdu dinhtungdu self-assigned this Jun 25, 2021
@jeffpaul jeffpaul merged commit b7d1d69 into develop Jun 28, 2021
@jeffpaul jeffpaul deleted the more-content-sync-updates branch June 28, 2021 17:58
@dinhtungdu dinhtungdu mentioned this pull request Jul 8, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

Assignees

@dinhtungdu dinhtungdu

Labels
None yet
Projects
None yet
Milestone
1.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@dinhtungdu @dkotter @jeffpaul