Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbers: support compact mode (2/2) #759

Merged
merged 2 commits into from
Aug 22, 2017

Conversation

rxaviers
Copy link
Member

No description provided.

@rxaviers
Copy link
Member Author

Updates:

  • Improved documentation
  • Squashed and rebased

@rxaviers
Copy link
Member Author

Much thanks to @sieverk 🎉

@rxaviers rxaviers merged commit a975fd7 into globalizejs:master Aug 22, 2017
@rxaviers rxaviers deleted the compact-mode branch August 22, 2017 13:15
@sieverk
Copy link
Contributor

sieverk commented Sep 11, 2017

Nah, sorry about all the holdup on my end. Much thanks for finishing up and merging!

@necolas
Copy link

necolas commented Oct 3, 2017

Please could a new version of the library including these changes be published?

@paularmstrong
Copy link

@rxaviers can we get a new version published with this, please?

@rxaviers
Copy link
Member Author

rxaviers commented Oct 5, 2017

@necolas and @paularmstrong, unfortuntely this feature isn't present in the examples and compiler tests ([1] and [2]). Can you help me get these updated? I can create an alpha release now to help it.

@rxaviers
Copy link
Member Author

rxaviers commented Oct 5, 2017

  • globalize@1.4.0-alpha.0

@necolas
Copy link

necolas commented Oct 5, 2017

At the moment we are forking several globalize packages. It would be great if you could publish non-alpha versions anyway and update examples, etc., later.

@rxaviers
Copy link
Member Author

rxaviers commented Oct 5, 2017

I feel your pain by working with forks, but an actual globalize release is supposed to be stable, including complete tests and docs/examples.

@diligiant
Copy link

@necolas I know the feeling ;( How about I do what's needed tomorrow morning (Europe) so @rxaviers can release 1.4 tomorrow?

@necolas
Copy link

necolas commented Oct 5, 2017

I feel your pain by working with forks

Twitter works with forks because it allows the team to make progress. Getting patches merged and released upstream here has been very slow so far :)

@rxaviers
Copy link
Member Author

rxaviers commented Oct 5, 2017

Getting patches merged and released upstream here has been very slow so far :)

Good old days where jQuery Foundation sponsored dedicated work for its projects, but the Foundation broke. Even working at PayPal with i18n (who uses globalize too), there's no immediate budget to work on the open source by itself. Instead it also has its forks and wrappers.

Thank you for your continued effort to bringing patches and improvements upstream for the greater good. I also believe on it and try my best to find time among the pile of growing work (and life stack) to get this moving. Unfortunately, my best response for now is that all help is appreciated.

@necolas
Copy link

necolas commented Oct 5, 2017

I'm concerned to hear that PayPal has also forked these projects and isn't contributing back upstream

@rxaviers
Copy link
Member Author

rxaviers commented Oct 5, 2017

PayPal contributed back timezone support and dateToParts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants