Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivot table #71

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Pivot table #71

merged 1 commit into from
Mar 22, 2024

Conversation

jim-sheldon
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.83%. Comparing base (7feafa1) to head (4f73899).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   63.41%   64.83%   +1.42%     
==========================================
  Files         171      150      -21     
  Lines        6278     4874    -1404     
  Branches     1722     1505     -217     
==========================================
- Hits         3981     3160     -821     
+ Misses       2297     1714     -583     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stanislaw-zakrzewski
Copy link
Collaborator

@jim-sheldon if we are not counting omit_error cases to the total counts shouldn't we also not count discarded cases?

@jim-sheldon
Copy link
Contributor Author

@jim-sheldon if we are not counting omit_error cases to the total counts shouldn't we also not count discarded cases?

Updated to exclude both

@jim-sheldon jim-sheldon merged commit 48098b8 into main Mar 22, 2024
4 checks passed
@jim-sheldon jim-sheldon deleted the pivot-table branch March 22, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants