Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not export fields with casereference metadata meaningless for users #161

Conversation

stanislaw-zakrzewski
Copy link
Collaborator

@stanislaw-zakrzewski stanislaw-zakrzewski commented Jan 15, 2025

Solves: #103

How it looked like:

image

Changes:

  • Do not export sourceId, sourceEntryId and uploadIds fields.

Testing:

Changes made to the exporter can be tested on this deployment.

Steps:
  1. Download dataset
Screenshot 2025-01-17 at 14 34 51 Screenshot 2025-01-17 at 14 35 23
  1. Unzip downloaded file:
gzip -d <<filename>>
  1. Check that file does not contain sourceId, sourceEntryId or uploadIds columns:
image

@stanislaw-zakrzewski stanislaw-zakrzewski added the work in progress There's still something left to do. label Jan 15, 2025
@stanislaw-zakrzewski stanislaw-zakrzewski self-assigned this Jan 15, 2025
@stanislaw-zakrzewski stanislaw-zakrzewski removed the work in progress There's still something left to do. label Jan 15, 2025
Copy link

@shaileshmahajanBCH shaileshmahajanBCH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stanislaw-zakrzewski for your explanation and efforts on this PR. Looks awesome!

@stanislaw-zakrzewski stanislaw-zakrzewski merged commit 4813d9c into main Jan 17, 2025
1 check passed
@stanislaw-zakrzewski stanislaw-zakrzewski deleted the 103-casereference-data-has-unneeded--confusing-column-data-b-g branch January 17, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CaseReference Data has unneeded / confusing column data B-G
2 participants