Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: registration data cache invalidation #6530

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

aberonni
Copy link
Contributor

@aberonni aberonni commented Feb 18, 2025

AB#33731

This makes sure that we invalidate cache for registration queries that rely on referenceId, as well as the queries that rely on registration.id

This was causing issues because the new "getDuplicates" endpoint (implemented in #6522) uses referenceId, and the cache for it was not being invalidated after editing personal information.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

https://lively-river-04adce503-6530.westeurope.5.azurestaticapps.net

AB#33731

This makes sure that we invalidate cache for registration queries that rely on referenceId, as well as the queries that rely on registration.id

This was causing issues because the new "getDuplicates" endpoint (implemented in #6522) uses referenceId, and the cache for it was not being invalidated after editing personal information.
@aberonni aberonni added the bugfix Something that affects our end users is fixed label Feb 18, 2025
@aberonni aberonni added chore Something that does not affect the end user bugfix Something that affects our end users is fixed and removed bugfix Something that affects our end users is fixed chore Something that does not affect the end user labels Feb 18, 2025
@aberonni aberonni marked this pull request as ready for review February 18, 2025 12:36
@Copilot Copilot bot review requested due to automatic review settings February 18, 2025 12:36
@aberonni aberonni enabled auto-merge (squash) February 18, 2025 12:36

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • interfaces/Portalicious/src/app/pages/project-registration-personal-information/project-registration-personal-information.page.html: Language not supported
  • interfaces/Portalicious/src/app/pages/project-registrations/components/import-registrations/import-registrations.component.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)

interfaces/Portalicious/src/app/domains/registration/registration.api.service.ts:308

  • Ensure that the 'registration' parameter is always an instance of 'Registration' before accessing its properties.
await Promise.all([
@aberonni aberonni merged commit 7faa4bd into main Feb 18, 2025
17 checks passed
@aberonni aberonni deleted the aberonni/fix-registrations-cache-invalidation branch February 18, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something that affects our end users is fixed
Development

Successfully merging this pull request may close these issues.

2 participants