Fix validation consistency of null values & send contact info to intersolve for intersolve attributes only #6527
Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
services/121-service/src/registration/validators/registrations-input-validator.ts:109
- [nitpick] The refactoring introduces an explicit if block for paymentAmountMultiplier; please ensure that tests cover scenarios where this attribute is undefined as well as defined to prevent regressions.
if (row.paymentAmountMultiplier !== undefined) {
services/121-service/src/registration/validators/registrations-input-validator.ts:146
- [nitpick] The added if block for validating scope should be verified by tests to confirm that both null and defined cases are handled consistently in the overall validation logic.
if (row[AdditionalAttributes.scope] !== undefined) {
services/121-service/src/registration/validators/registrations-input-validator.spec.ts
Outdated
Show resolved
Hide resolved
RubenGeo
changed the title
RubenGeo
force-pushed
the
fix.validate-payment-amount-multiplier
branch
from
6523fcf to
935990d
Compare
RubenGeo
force-pushed
the
fix.validate-payment-amount-multiplier
branch
from
935990d to
cf206e5
Compare
| @@ -668,7 +668,14 @@ export class RegistrationsService { | |||
| }); | |||
| } | |||
|
|
|||
| if (process.env.SYNC_WITH_THIRD_PARTIES) { | |||
There was a problem hiding this comment.
Rename will make this a bit cleaner? Something like: SEND_UPDATED_CONTACT_INFORMATION_TO_INTERSOLVE
There was a problem hiding this comment.
Renaming an ENV-variable that is already used in production isn't the easiest though...
The existing instances that have it set need to add the new ENV-variable first; So that it can be used during the next deployment.
AFTER that deployment, the old ENV-variable needs to be removed again. (to prevent confusion later)
There was a problem hiding this comment.
But besides that, I'm all for "naming things as explicitly as possible" :D
There was a problem hiding this comment.
I agree with elwin here to keep it out of the scope of this fix
diderikvw
force-pushed
the
fix.validate-payment-amount-multiplier
branch
from
cf206e5 to
f6b69b9
Compare
AB#33713 AB#33701
Describe your changes
Send contact info to intersolve for intersolve attributes only & make validations of registration updates more consistent
See bug item
Checklist before requesting a review
Portalicious preview deployment
This PR does not have any preview deployments yet.