Replace glitch-soc's collapsed toots with upstream's “Read more” #2916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
force-pushed
the
glitch-soc/collapsed-read-more
branch
from
44365a6 to
8b40070
Compare
ClearlyClaire
force-pushed
the
glitch-soc/collapsed-read-more
branch
from
8b40070 to
48faf66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glitch-soc implemented “collapsed toots”, a way of reducing long posts to a few pixels of height.
While practical, this design has a few issues:
Furthermore, this feature increases glitch-soc's code complexity quite a bit and is one of the large source of differences with upstream.
Therefore, this PR removes the feature, to replace it with upstream's “Read more” design.