Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oiy. How many times have we been bitten by this same thing? Any chance of making
@glimmer/object-reference
a private package that doesn’t get published (while we fix glimmer-vm’s test suite to not rely on it)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwjblue Yeah, seriously. There is one usage of it left in Glimmer.js, actually, that was not as simple to fix as this one because the circular dependency breaks initialization.
We could fix that in the interim by hoisting the references stuff in
@glimmer/component
into a separate package (@glimmer/component-reference
?), but I think the real solution is to hoist the reference implementation up intoglimmer-vm
so that it can be shared by both Glimmer.js and Ember.js (we'll need this imminently for interop between the two, anyway).I know @krisselden had some ideas for a strawman API for creating composable references from multiple environments. I'd like to understand the level of effort for that to decide if we should do something temporary to fix this, or just bite the bullet and build the composable system we'll need soon anyway.