Improve bytecode compilation #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadhietala
reviewed
Nov 9, 2017
| }, | ||
| "devDependencies": { | ||
| "@glimmer/application-test-helpers": "^0.9.0-alpha.4", | ||
| "@glimmer/component": "^0.9.0-alpha.4", | ||
| "@glimmer/wire-format": "^0.29.10", | ||
| "@glimmer/test-helpers": "^0.30.1", |
chadhietala
reviewed
Nov 9, 2017
| @@ -210,6 +210,7 @@ if (DEBUG) { | |||
| .template('Main', '<h1>Hello, {{name}}!</h1>') | |||
| .boot(); | |||
| } catch (err) { | |||
| console.log(err.message); | |||
chadhietala
approved these changes
Nov 9, 2017
Turbo87
pushed a commit
to Turbo87/glimmer.js
that referenced
this pull request
Nov 24, 2017
Support Glimmer 0.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a grab-bag of improvements to the toolchain for compiling applications to Glimmer bytecode.
In particular, this PR:
@glimmer/compiler-delegates) to use the newModuleLocator/TemplateLocatorsystem for addressing buildtime metadata, and being more rigorous about handling runtime template metadata.