[BUGFIX] Fixes args tracking in Glimmer component #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 15, 2019 17:28
`@tracked` is not yet avalibale for general usage in Ember apps, so we were relying on using the interop with `get` and `set` to track args. However, we never actually used `get`, so it wasn't picking it up. This ensures that all gets/sets of the field go through the proper codepaths, and will be autotracked.
|
This seems fine for now, but I would like to update to something akin to what was done in: Even though that was for glimmer.js's version, the code is roughly the same in Ember (going back a ways now). |
rwjblue
approved these changes
Mar 18, 2019
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trackedis not yet avalibale for general usage in Ember apps,so we were relying on using the interop with
getandsetto track args. However, we never actually usedget,so it wasn't picking it up. This ensures that all gets/sets of
the field go through the proper codepaths, and will be autotracked.