Use yarn to install package dependencies #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is not happy 😿 |
|
@rwjblue Ack, thanks for catching that. I made a booboo and was configuring the extra args as a string when it was supposed to be an array. I think this is good to go now and is much faster than npm, but we should try to switch to Yarn workspaces after we break the circular dependency. |
rwjblue
approved these changes
Oct 9, 2017
chadhietala
reviewed
Oct 9, 2017
| @@ -3,5 +3,7 @@ | |||
| "packages": [ | |||
| "packages/@glimmer/*" | |||
| ], | |||
| "npmClient": "yarn", | |||
| "npmClientArgs": ["--no-lockfile"], | |||
There was a problem hiding this comment.
I don’t remember; didn’t we pair on this PR? 🎃 I don’t remember if this is disabled because it caused problems or just to preserve existing Lerna/npm semantics. If we use workspaces then these would get hoisted to the root yarn.lock anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.