Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move getOwner out of component manager #149

Merged
merged 4 commits into from
Oct 3, 2018
Merged

Move getOwner out of component manager #149

merged 4 commits into from
Oct 3, 2018

Conversation

smfoote
Copy link
Contributor

@smfoote smfoote commented Oct 2, 2018

Addresses the first part of #146

chadhietala
chadhietala reviewed Oct 3, 2018
View reviewed changes
packages/@glimmer/application/src/environment.ts Outdated
}

setOwner(obj: Object, owner: Owner): void {
return setOwner(obj, owner);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to return here.

@chadhietala chadhietala merged commit 459662e into glimmerjs:master Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadhietala chadhietala chadhietala left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smfoote @chadhietala @rwjblue