Skip to content

Commit

Permalink
Use volta to manage the "default" node / yarn versions.
Browse files Browse the repository at this point in the history
Ideally we would not have to duplicate the version info for each of the
`package.json`s, but until Volta provides a way to properly manage
nested workspaces this is the best we can do.
  • Loading branch information
rwjblue committed Apr 2, 2020
1 parent ac5963d commit 5ca50dc
Show file tree
Hide file tree
Showing 12 changed files with 47 additions and 11 deletions.
10 changes: 0 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
with:
node-version: 12
yarn-version: 1.22.4
- run: yarn install --frozen-lockfile --non-interactive
- run: yarn lint
- run: yarn build
Expand All @@ -35,7 +32,6 @@ jobs:
- uses: volta-cli/action@v1
with:
node-version: ${{ matrix.node-version }}
yarn-version: 1.22.4
- run: yarn install --frozen-lockfile --non-interactive
- run: yarn test:babel-plugins

Expand All @@ -46,9 +42,6 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
with:
node-version: 12
yarn-version: 1.22.4
- run: yarn install --frozen-lockfile --non-interactive
- run: yarn testem ci

Expand All @@ -63,8 +56,5 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
with:
node-version: 12
yarn-version: 1.22.4
- run: yarn install --frozen-lockfile --non-interactive
- run: yarn test:ember ember-${{ matrix.ember-version }} --skip-cleanup
8 changes: 7 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@
},
"release-it-yarn-workspaces": {
"additionalManifests": {
"dependencyUpdates": ["packages/@glimmer/blueprint/files/package.json"]
"dependencyUpdates": [
"packages/@glimmer/blueprint/files/package.json"
]
}
}
},
Expand All @@ -111,5 +113,9 @@
"tokenRef": "GITHUB_AUTH"
},
"npm": false
},
"volta": {
"node": "12.16.1",
"yarn": "1.22.4"
}
}
4 changes: 4 additions & 0 deletions packages/@glimmer/blueprint/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,9 @@
},
"ember-addon": {
"main": "ember-addon-main.js"
},
"volta": {
"node": "12.16.1",
"yarn": "1.22.4"
}
}
4 changes: 4 additions & 0 deletions packages/@glimmer/component/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,5 +90,9 @@
"configPath": "tests/dummy/config",
"defaultBlueprint": "install-glimmer-component",
"main": "ember-addon-main.js"
},
"volta": {
"node": "12.16.1",
"yarn": "1.22.4"
}
}
4 changes: 4 additions & 0 deletions packages/@glimmer/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,9 @@
"@glimmer/compiler": "^0.50.0",
"@glimmer/component": "2.0.0-beta.3",
"@glimmer/tracking": "2.0.0-beta.3"
},
"volta": {
"node": "12.16.1",
"yarn": "1.22.4"
}
}
4 changes: 4 additions & 0 deletions packages/@glimmer/helper/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,9 @@
"@glimmer/core": "2.0.0-beta.3",
"@glimmer/interfaces": "^0.50.0",
"@glimmer/reference": "^0.50.0"
},
"volta": {
"node": "12.16.1",
"yarn": "1.22.4"
}
}
4 changes: 4 additions & 0 deletions packages/@glimmer/modifier/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,9 @@
"dependencies": {
"@glimmer/interfaces": "^0.50.0",
"@simple-dom/interface": "^1.4.0"
},
"volta": {
"node": "12.16.1",
"yarn": "1.22.4"
}
}
4 changes: 4 additions & 0 deletions packages/@glimmer/ssr/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,9 @@
},
"devDependencies": {
"@glimmer/component": "2.0.0-beta.3"
},
"volta": {
"node": "12.16.1",
"yarn": "1.22.4"
}
}
4 changes: 4 additions & 0 deletions packages/@glimmer/tracking/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,9 @@
"@glimmer/interfaces": "^0.50.0",
"@glimmer/resolver": "^0.3.0",
"@glimmer/wire-format": "^0.50.0"
},
"volta": {
"node": "12.16.1",
"yarn": "1.22.4"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,9 @@
"babel-plugin-tester": "^6.4.0",
"esm": "^3.2.25",
"mocha": "^6.2.0"
},
"volta": {
"node": "12.16.1",
"yarn": "1.22.4"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,9 @@
"chai": "^4.2.0",
"esm": "^3.2.25",
"mocha": "^6.2.0"
},
"volta": {
"node": "12.16.1",
"yarn": "1.22.4"
}
}
4 changes: 4 additions & 0 deletions packages/example-apps/basic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,9 @@
"@glimmer/tracking": "^1.0.0",
"@glimmer/helper": "^1.0.0",
"@glimmer/modifier": "^1.0.0"
},
"volta": {
"node": "12.16.1",
"yarn": "1.22.4"
}
}

0 comments on commit 5ca50dc

Please sign in to comment.