Add a set of "chaos monkey" tests for rehydration. #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
chaos-monkey
branch
3 times, most recently
from
69862b3 to
62515c6
Compare
|
Some ideas that @krisselden just mentioned to me in DM:
|
rwjblue
force-pushed
the
chaos-monkey
branch
7 times, most recently
from
bf8029c to
aec2bcf
Compare
|
is this still a WIP? |
rwjblue
force-pushed
the
chaos-monkey
branch
from
aec2bcf to
ab7a6a1
Compare
|
Thanks for the reminder @krisselden, rebased and updated. Should be good to land once green. |
This adds tests that run a number of iterations removing a random node, and confirming that the final rehydrated (e.g. client rendered) HTML is correct. In order to make these tests actionable the infrastructure added here provides a way to replicate _specific_ iterations upon failure. The way this works is based on QUnit's internal `QUnit.config.seed` implementation. When a `QUnit` test suite is ran with the `seed` query param set (with no value e.g. `/tests/index.html?hidepassed&seed`), QUnit will choose a random seed and use that seed to choose a randomized test order. Then if a failure occurs with the randomized and seeded test run, you can run the tests again with **exactly** that seed value by specifying the `seed` query param _with_ the failing seed value (e.g. `/tests/index.html?hidepassed&seed=THEVALUEHERE`). The implementation here piggie backs on that system to use the QUnit's seed value (along with a copied version of their [hashing function](qunitjs/qunit:src/core/utilities.js@2.9.3#L144-L158) and [seeded randomizer](qunitjs/qunit:src/core/processing-queue.js@2.9.3#L134-L154)) in addition to the iteration being ran to always select a "known value" to remove. This means that given the correct seed (and iteration number) we can easily replicate **specific** failure scenarios without manually having to track it down. The way you'd do this is: 1. Run the tests with `/tests/index.html?hidepassed&seed` until a failure occurs. 2. Look at the failed tests assertion, grab the rerun URL printed in the failed assertion. 3. Run the tests again with that set of query params (e.g. `/tests/index.html?hidepassed&seed=SEED_HERE&iteration=ITERATION_HERE`).
rwjblue
force-pushed
the
chaos-monkey
branch
from
ab7a6a1 to
5164ba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on an idea that @krisselden and I had while working on #988 this adds tests that run a number of iterations removing a random node, and confirming that the final rehydrated (e.g. client rendered) HTML is correct.
In order to make these tests actionable the infrastructure added here provides a way to replicate specific iterations upon failure. The way this works is based on QUnit's internal
QUnit.config.seedimplementation. When aQUnittest suite is ran with theseedquery param set (with no value e.g./tests/index.html?hidepassed&seed), QUnit will choose a random seed and use that seed to choose a randomized test order. Then if a failure occurs with the randomized and seeded test run, you can run the tests again with exactly that seed value byspecifying the
seedquery param with the failing seed value (e.g./tests/index.html?hidepassed&seed=THEVALUEHERE). The implementation here piggie backs on that system to use the QUnit's seed value (along with a copied version of their hashing functionand seeded randomizer) in addition to the iteration being ran to always select a "known value" to remove. This means that given the correct seed (and iteration number) we can easily replicate specific failure scenarios without manually having to track it down.
The way you'd do this is:
/tests/index.html?hidepassed&seeduntil a failure occurs./tests/index.html?hidepassed&seed=SEED_HERE&iteration=ITERATION_HERE).Currently includes the changes from #988, but will rebase once that lands.