Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not have nested packages #1614

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Do not have nested packages #1614

merged 1 commit into from
Sep 11, 2024

Conversation

NullVoxPopuli
Copy link
Contributor

These can be handy ergo tools -- but they (currently) are confusing release-plan

@NullVoxPopuli NullVoxPopuli merged commit 48c5eb1 into main Sep 11, 2024
8 checks passed
@NullVoxPopuli NullVoxPopuli deleted the no-nested-packages branch September 11, 2024 21:42
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
Copy link

duration phase no difference [-93ms to 161ms]
renderEnd phase no difference [-3ms to 0ms]
render1000Items1End phase no difference [-4ms to 18ms]
clearItems1End phase no difference [-3ms to 3ms]
render1000Items2End phase no difference [-10ms to 16ms]
clearItems2End phase no difference [-2ms to 0ms]
render5000Items1End phase estimated regression +38ms [5ms to 70ms] OR +1.05% [0.13% to 1.92%]
clearManyItems1End phase no difference [-4ms to 2ms]
render5000Items2End phase no difference [-26ms to 36ms]
clearManyItems2End phase no difference [-4ms to 2ms]
render1000Items3End phase no difference [-24ms to 15ms]
append1000Items1End phase no difference [-29ms to 28ms]
append1000Items2End phase no difference [-12ms to 11ms]
updateEvery10thItem1End phase no difference [-5ms to 2ms]
updateEvery10thItem2End phase no difference [-1ms to 0ms]
selectFirstRow1End phase no difference [0ms to 0ms]
selectSecondRow1End phase no difference [0ms to 0ms]
removeFirstRow1End phase no difference [-5ms to 1ms]
removeSecondRow1End phase no difference [-1ms to 1ms]
swapRows1End phase no difference [-1ms to 1ms]
swapRows2End phase no difference [-1ms to 0ms]
clearItems4End phase no difference [-2ms to 1ms]
paint phase no difference [0ms to 0ms]

[22:23:28] Generating Benchmark Reports [started]
[22:23:36] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant