Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stricter type for createPrimitiveRef #1483

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Use stricter type for createPrimitiveRef #1483

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9282779
Use stricter type
NullVoxPopuli Nov 1, 2023
34b8cad
Update packages/@glimmer/reference/lib/reference.ts
chancancode Nov 20, 2023
2dc0d64
Merge branch 'master' into stricter-makePrimitiveRef
chancancode Nov 20, 2023
43cf897
Update packages/@glimmer/reference/lib/reference.ts
chancancode Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@glimmer/reference/lib/reference.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class ReferenceImpl<T = unknown> implements Reference<T> {
}
}

export function createPrimitiveRef<T>(value: T): Reference<T> {
export function createPrimitiveRef<T extends string| symbol | number | boolean | null | undefined>(value: T): Reference<T> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, maybe bigint too, I am not sure we have a use case for it?

const ref = new ReferenceImpl<T>(UNBOUND);

ref.tag = CONSTANT_TAG;
Expand Down