Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare @glimmer/local-debug-flags #1461

Closed

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Oct 24, 2023

Ran in to this while trying to upgrade the vm in ember: emberjs/ember.js#20561

We can't import packages without declaring them in dependencies or peerDependencies. Since the local-debug-flags package is entirely wrapped in import.meta.env guards, then we can include it and rely on build to remove / svelte away the unused blocks.

@NullVoxPopuli
Copy link
Contributor Author

I think I'm going to take a different approach with this actually.

gonna add a custom plugin to rollup to remove references to this package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant