[BUGFIX] Fix {{get}} when used on non-objects #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `{{get}}` would not work on non-object values, even though
they may have had properties (e.g. `String.length`). This PR fixes this
and makes sure that `{{get}}` has the same behavior as directly
referencing the property in a template without using `{{get}}`.
pzuraq
force-pushed
the
bugfix/fix-get-helper-on-non-objects
branch
from
73da183 to
7ebdc05
Compare
rwjblue
reviewed
Feb 15, 2021
| @@ -88,21 +89,17 @@ export default internalHelper((args: VMArguments) => { | |||
| () => { | |||
| let source = valueForRef(sourceRef); | |||
|
|
|||
| if (isObject(source)) { | |||
| if (isDict(source)) { | |||
There was a problem hiding this comment.
For the lazy, this is doing source !== null && source !== undefined
glimmer-vm/packages/@glimmer/util/lib/collections.ts
Lines 13 to 15 in 1a54cba
rwjblue
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
{{get}}would not work on non-object values, even thoughthey may have had properties (e.g.
String.length). This PR fixes thisand makes sure that
{{get}}has the same behavior as directlyreferencing the property in a template without using
{{get}}.Fixes emberjs/ember.js#19400