Ensure {{component.name}} works with implicit this fallback in loose mode.
#1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
repro-emberjs-19313
branch
from
e937f1e to
3d1ed89
Compare
* Using a named argument of `@component` is valid, as is using paths off of it. * Using an implicit this fallback of `component.name` is valid for paths
rwjblue
force-pushed
the
repro-emberjs-19313
branch
from
3d1ed89 to
1e2e4e8
Compare
pzuraq
approved these changes
Dec 21, 2020
When in loose mode referencing `{{component.name}}` **must** mean
relying on implicit this fallback as `{{this.component.name}}`. The
existing code always assumes that any `PathExpression` _starting_ with a
keyword name (as its first path part) **must** be a keyword invocation.
This change ensures that `{{component.name}}` can properly fallback to
`{{this.component.name}}` when running in loose mode, and emits a
helpful error when running in strict mode.
rwjblue
force-pushed
the
repro-emberjs-19313
branch
from
1e2e4e8 to
e0df20a
Compare
pzuraq
approved these changes
Dec 21, 2020
rwjblue
changed the title
{{@component.foo}}{{component.name}} works with implicit this fallback in loose mode.
|
wondering, should we add same check for |
@lifeart - What do you mean? |
|
@rwjblue I mean |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempts to reproduce emberjs/ember.js#19313