Add a previously failing test for destroyables not being called on items added to an {{#each after initial render
#1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Apr 14, 2020
scottmessinger
force-pushed
the
destroy-error-in-each
branch
from
9457dc5 to
a2850b8
Compare
|
OK, I think this should pass now if you rebase... |
Failing test for emberjs/ember.js#18855 Fix destroyCount for last assert
scottmessinger
force-pushed
the
destroy-error-in-each
branch
from
a2850b8 to
19f1962
Compare
|
@rwjblue Rebased and tests now pass! |
rwjblue
changed the title
{{#each after initial render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understand the problem correctly, I think this is a failing test for emberjs/ember.js#18855
Let me know if there's anything I can do to help!