Enable eslint-plugin-node's no-extraneous-import rule (mostly). #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
commented
Feb 19, 2020
rwjblue
force-pushed
the
enable-no-extraneous-import
branch
from
da33cc3 to
460d84c
Compare
This enables eslint-plugin-node's `no-extraneous-import` rule (which is part of its recommended set) for all packages _except_ `@glimmer/interfaces`. `@glimmer/interfaces` is excluded because IMHO it **should not** have any external dependencies, and the imports here need to be refactored to avoid needing to add the dependency. A single test in `@glimmer/reference` is excluded because it is specifically importing from `@glimmer/runtime` (which causes a cyclic dependency) and should probably either be moved into `@glimmer/runtime` itself or refactored to using the base interfaces instead of the implementations from `@glimmer/runtime`. This change however helps us ensure we don't _accidentally_ regress for all of the other packages...
rwjblue
force-pushed
the
enable-no-extraneous-import
branch
from
460d84c to
73c7b67
Compare
krisselden
approved these changes
Feb 19, 2020
|
CI is green, but the GH status isn't updated, merging.... |
This was referenced Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables eslint-plugin-node's
no-extraneous-importrule (which is part of its recommended set) for all packages except@glimmer/interfaces.I've excluded
@glimmer/interfacesspecifically because IMHO it should not have any external dependencies, and the imports here need to be refactored to avoid needing to add the dependency.This change however helps us ensure we don't accidentally regress for all of the other packages...