test(nvme): check nqn, model and serial

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb · Sep 22, 2023 · 3981de4 · 3981de4
1 parent 81e7d51
commit 3981de4
Showing 1 changed file with 49 additions and 0 deletions.
diff --git a/pkg/frontend/nvme_subsystem_test.go b/pkg/frontend/nvme_subsystem_test.go
@@ -8,6 +8,7 @@ package frontend
 import (
 	"fmt"
 	"reflect"
+	"strings"
 	"testing"
 
 	"google.golang.org/protobuf/proto"
@@ -151,6 +152,54 @@ func TestFrontEnd_CreateNvmeSubsystem(t *testing.T) {
 			"missing required field: nvme_subsystem",
 			false,
 		},
+		"too long nqn field": {
+			id: testControllerID,
+			in: &pb.NvmeSubsystem{
+				Name: testSubsystemName,
+				Spec: &pb.NvmeSubsystemSpec{
+					Nqn:          strings.Repeat("a", 224),
+					SerialNumber: strings.Repeat("b", 20),
+					ModelNumber:  strings.Repeat("c", 40),
+				},
+			},
+			out:     nil,
+			spdk:    []string{},
+			errCode: codes.InvalidArgument,
+			errMsg:  fmt.Sprintf("Nqn value (%s) is too long, have to be between 1 and %d", strings.Repeat("a", 224), 223),
+			exist:   false,
+		},
+		"too long model field": {
+			id: testControllerID,
+			in: &pb.NvmeSubsystem{
+				Name: testSubsystemName,
+				Spec: &pb.NvmeSubsystemSpec{
+					Nqn:          strings.Repeat("a", 223),
+					SerialNumber: strings.Repeat("b", 20),
+					ModelNumber:  strings.Repeat("c", 41),
+				},
+			},
+			out:     nil,
+			spdk:    []string{},
+			errCode: codes.InvalidArgument,
+			errMsg:  fmt.Sprintf("ModelNumber value (%s) is too long, have to be between 1 and %d", strings.Repeat("c", 41), 40),
+			exist:   false,
+		},
+		"too long serial field": {
+			id: testControllerID,
+			in: &pb.NvmeSubsystem{
+				Name: testSubsystemName,
+				Spec: &pb.NvmeSubsystemSpec{
+					Nqn:          strings.Repeat("a", 223),
+					SerialNumber: strings.Repeat("b", 21),
+					ModelNumber:  strings.Repeat("c", 40),
+				},
+			},
+			out:     nil,
+			spdk:    []string{},
+			errCode: codes.InvalidArgument,
+			errMsg:  fmt.Sprintf("SerialNumber value (%s) is too long, have to be between 1 and %d", strings.Repeat("b", 21), 20),
+			exist:   false,
+		},
 	}
 
 	// run tests