Add support for Consul TTLs and multiple checks. #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may potentially close #57, depending on how the original author wishes to solve the problem. On each refresh, Registrator will write the current timestamp into the check's notes. Further, this change also introduces the ability to have multiple health checks types. For example, a TTL may be used in conjunction with a script. This allows for a more reliable service discovery mechanism, reducing the risk of services reclaiming old ports. These changes also open the door for a simple, native HTTP check integration with Consul. Because Registrator doesn't currently have an API to store the upstream state of the service (i.e. remote check IDs), the Consul adapter filters the defined checks into an ordered list, which it then correlates to the check ID in Consul based on index. Consul's API implementation suggests this is safe, however, this behaviour is not documented. Sadly, this breaks compatibility with Consul 0.4.x, which only supported one service check per service.
|
+1 |
3 similar comments
|
+1 |
|
+1 |
|
+1 |
| @@ -21,6 +21,8 @@ All notable changes to this project will be documented in this file. | |||
| ### Changed | |||
| - Overall refactoring and cleanup | |||
| - Decoupled registries into subpackages using extpoints | |||
| - Add full TTL support for Consul 0.5.0. | |||
There was a problem hiding this comment.
Please mention that it breaks compat with Consul 0.4 in changelog
|
And rebase and we'll merge :) |
|
+1 |
|
@burnison, would you please rebase your branch so this PR can be merged. would love to see multiple types of consul health checks supported 😸 |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may potentially close #57, depending on how the original author wishes to
solve the problem. On each refresh, Registrator will write the current timestamp into
the check's notes.
Further, this change also introduces the ability to have multiple health checks
types. For example, a TTL may be used in conjunction with a script. This allows
for a more reliable service discovery mechanism, reducing the risk of services
reclaiming old ports. These changes also open the door for a simple, native HTTP
check integration with Consul. Because Registrator doesn't currently have an API
to store the upstream state of the service (i.e. remote check IDs), the Consul
adapter filters the defined checks into an ordered list, which it then
correlates to the check ID in Consul based on index. Consul's API implementation
suggests this is safe; however, this behaviour is not documented.
Sadly, this breaks compatibility with Consul 0.4.x, which only supported one
service check per service.