fix: const generation for not string types (#2333) #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielBretzigheimer
force-pushed
the
feature/const_generation_fix
branch
from
6a2d472 to
24b7f41
Compare
|
I'm running in to the issue that this pr resolves - any chance we could get movement on this? it's been open for a year now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the bug in #2333, but I had to disable the functionality to generate const for not string types. The problem is that the cases in line 957 in
JSONSchemaInput.tscurrently expect the cases to be strings. But for const generation they could be every type which causes an error when the names are generated.I may look into it when I have time, for now, I have added a FIXME comment. If someone would like to address this issue, feel free to fix this.