Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that Row IDs are returned in the same order/index as the rows added #2

Closed
activescott opened this issue Jul 24, 2024 · 1 comment · Fixed by #35
Closed

Clarify that Row IDs are returned in the same order/index as the rows added #2

activescott opened this issue Jul 24, 2024 · 1 comment · Fixed by #35
Assignees

Comments

@activescott
Copy link
Contributor

WRT

"description": "Row IDs of added rows, e.g.,\n\n```json\n[\n\t\"2a1bad8b-cf7c-44437-b8c1-e3782df6\",\n\t\"93a19-cf7c-44437-b8c1-e9acbbb\"\n]\n```"

I assume that I can map the index of the row added in the rquest to the index of the row ID in the response, is that correct? If so, we should clarify. If not, how can we map a row ID to the input row?

Also we should clarify what happens when one row of a batch fails to get added. Is it a different status code? Is the whole batch failed, or did some of the rows get added? What is in rowID response? How do I read the descriptive error message about why it failed to add, etc. etc.

@rwdaigle
Copy link
Contributor

rwdaigle commented Aug 1, 2024

Agreed.

re: unknownColumns option: https://github.com/glideapps/glide/issues/28119

chkn added a commit that referenced this issue Dec 13, 2024
@chkn chkn linked a pull request Dec 13, 2024 that will close this issue
@chkn chkn closed this as completed in #35 Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants