Allow "add-disk --controller sata" #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jushengfeng
reviewed
Jan 25, 2018
jushengfeng
approved these changes
Jan 25, 2018
Signed-off-by: Glenn Matthews <glmatthe@cisco.com>
glennmatthews
force-pushed
the
feature/add-disk-sata
branch
from
d6487b1
to
0f8e011
Compare
Codecov Report
@@ Coverage Diff @@
## develop #72 +/- ##
========================================
Coverage 96.23% 96.23%
========================================
Files 56 56
Lines 5313 5313
Branches 1042 1042
========================================
Hits 5113 5113
Misses 93 93
Partials 107 107
Continue to review full report at Codecov.
|
glennmatthews
added a commit
that referenced
this pull request
Jan 29, 2018
Version 2.1.0 - Fix PATH issues with bin/cot helper script - Permit "cot add-disk ... --controller sata" (#72)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turned out simpler than expected!