Skip to content

Commit

Permalink
Code Modernization: Rename parameters that use reserved keywords in `…
Browse files Browse the repository at this point in the history
…phpunit/tests/widgets/wpWidgetMedia.php`.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the `$object` parameter to `$widget` in `Tests_Widgets_wpWidgetMedia::filter_widget_mocked_instance()`.

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945], [54946], [54947], [54948], [54950], [54951], [54952], [54956], [54959], [54960], [54961], [54962], [54964], [54965], [54969], [54970], [54971], [54972], [54996], [55000], [55011], [55013], [55014], [55015], [55016], [55017], [55020], [55021], [55023], [55027], [55028], [55034], [55036], [55037], [55038], [55039], [55049], [55050], [55060], [55062], [55064], [55065], [55076], [55077], [55078], [55081], [55090], [55100], [55104], [55112], [55115], [55116], [55117], [55119].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

git-svn-id: https://develop.svn.wordpress.org/trunk@55120 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information
SergeyBiryukov committed Jan 23, 2023
1 parent 698c003 commit 0ab4ae8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/phpunit/tests/widgets/wpWidgetMedia.php
Original file line number Diff line number Diff line change
Expand Up @@ -383,10 +383,10 @@ public function test_widget() {
*
* @param array $instance Instance data.
* @param array $args Widget args.
* @param WP_Widget_Media $object Widget object.
* @param WP_Widget_Media $widget Widget object.
* @return array Instance.
*/
public function filter_widget_mocked_instance( $instance, $args, $object ) {
public function filter_widget_mocked_instance( $instance, $args, $widget ) {
$this->widget_instance_filter_args = func_get_args();
return $instance;
}
Expand Down

0 comments on commit 0ab4ae8

Please sign in to comment.