Force mutable Strings to address upcoming Ruby default frozen strings #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby is slowly moving towards using frozen string literals by default [1]. As of Ruby 3.4 it now produces a warning whenever a String literal modifies a value which will be default frozen in the future. From this project: ``` lib/graphviz.rb:533: warning: literal string will be frozen in the future (run with --debug-frozen-string-literal for more information) lib/graphviz/dot_script.rb:58: warning: literal string will be frozen in the future (run with --debug-frozen-string-literal for more information) ``` This change minimally modifies the places where a mutable String is required to use String.new instead of a bare String literal. This is a no-op for existing apps not using default frozen strings, but allows all the benefits for applications supporting it. Running the tests with the upcoming behavior enabled on Ruby 3.4: ``` RUBYOPT="--enable=frozen_string_literal" rake ``` Before: ``` 100 tests, 303 assertions, 71 failures, 5 errors, 0 pendings, 0 omissions, 0 notifications 24% passed ``` After: ``` 100 tests, 258 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed ``` [1] https://bugs.ruby-lang.org/issues/20205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby is slowly moving towards using frozen string literals by default. As of Ruby 3.4 it now produces a warning whenever a String literal modifies a value which will be default frozen in the future.
From this project:
This change minimally modifies the places where a mutable String is required to use String.new instead of a bare String literal. This is a no-op for existing apps not using default frozen strings, but allows all the benefits for applications supporting it.
Running the tests with the upcoming behavior enabled on Ruby 3.4:
Before:
After: