Allow configuring translation backend in yaml #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredmoody
force-pushed
the
configurable-translation-backend
branch
2 times, most recently
from
613a540 to
3e59981
Compare
davidwessman
changed the title
|
Fixes #575 |
glebm
reviewed
May 27, 2024
|
Just posted #581 which is a prerequisite to this PR. |
jaredmoody
force-pushed
the
configurable-translation-backend
branch
from
3e59981 to
903d26d
Compare
|
By placing the backend default in the suggested location, there's now a |
|
That's fine, please disable |
|
Looks good to me! Disable the rubocop warning and I'll merge 👍 |
davidwessman
reviewed
Jun 9, 2024
- Use the Enum option parser for the translation_backend to prevent fallback to `en` - Add `allow_blank` argument to the Enum option parser. We want -b to be optional so we can use the config file backend if present - Update translation strings for translation_backend CLI argument to list all options - Error when invalid backend is specified - Retain :google backend default, specify in `I18n::Tasks::Configuration#translation_config` - Tidy README to remove duplication and show backend configuration via config file
jaredmoody
force-pushed
the
configurable-translation-backend
branch
from
dec2290 to
ebe6e02
Compare
|
Thank you! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also tidied up the README to be a little more concise and added examples of backend configuration under each translation backend configuration section.
LMK if you would like any changes.