Ignore non-html interpolations in DeepL Translator #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in [DeepL xml docs](https://www.deepl.com/docs-api/xml) `ignore_tags` can only be used when `tag_handling=xml` It worked in the Spanish example, because it is not translating user in this context. Co-authored-by: Jalyna Schröder <js@zaikio.com>
|
I think this implies that the input to DeepL should be valid XML (or perhaps HTML), so you should also HTML-escape non-HTML values when sending them to DeepL and then HTML-unescape the results. |
|
I just saw this PR after making my own :/ |
|
This is related to #417 |
|
@PolinaStamenova can you try it out on main now? |
|
Superceded by #523 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in DeepL xml docs
ignore_tagscan only be used whentag_handling=xmlIt worked in the Spanish example, because it is not translating user in this context.
We discovered this bug by translating a bigger project and it happened to more than the half of our translations.
As you can see we added regression test. Enabling
xmldoes work in our code base without any side effects.