Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'config' option usage in CLI #455

Merged
merged 1 commit into from
May 20, 2022
Merged

Fix 'config' option usage in CLI #455

merged 1 commit into from
May 20, 2022

Conversation

shev-vadim-net
Copy link
Contributor

This PR fixes the #409 issue.

As I understand the config option is not fully added into the gem. It's used only in the I18n::Tasks::BaseTask.new and nowhere else. This change just removes config from the arguments. Now all the CLI commands work as expected when providing a custom configuration file.

@davidwessman
Copy link
Collaborator

Cool!

@geoffharcourt Can you see if this solves your problems?

@geoffharcourt
Copy link

Woot! This fixed it! @shev-vadim-net thanks for the find and the fix! We use i18n-tasks in two different setups, so this lets us remove a massive hack we had been using (copying config files over the canonical location).

@glebm glebm merged commit a2adc31 into glebm:main May 20, 2022
@glebm
Copy link
Owner

glebm commented May 20, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants