Adds Rails matcher for AST-scanners #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
davidwessman
commented
Mar 27, 2022
davidwessman
commented
- AST-matching is extracted to a class.
- Adds a class for matching Rails model translations.
|
Shall we merge this before #436? |
No, I think we should do the comments first. Will see if I can get some more time to work on it today. |
davidwessman
force-pushed
the
ast-match-rails
branch
4 times, most recently
from
22e1d38
to
d24baa4
Compare
davidwessman
commented
Apr 2, 2022
davidwessman
commented
Apr 2, 2022
davidwessman
force-pushed
the
ast-match-rails
branch
from
d24baa4
to
f1bfbe8
Compare
davidwessman
changed the title
glebm
reviewed
Apr 3, 2022
davidwessman
force-pushed
the
ast-match-rails
branch
2 times, most recently
from
1b70818
to
43db5dc
Compare
- Adds `add_ast_matcher` to tasks similar to scanners.
- Adds a class for matching Rails model translations.
- User.human_attribute_name('name') and User.model_name.human(count: 2).
davidwessman
force-pushed
the
ast-match-rails
branch
from
43db5dc
to
cb9db53
Compare
glebm
approved these changes
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.