-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Yandex translator option to translate_missing functionality #343
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'i18n/tasks/translators/base_translator' | ||
|
||
module I18n::Tasks::Translators | ||
class YandexTranslator < BaseTranslator | ||
def initialize(*) | ||
begin | ||
require 'yandex-translator' | ||
rescue LoadError | ||
raise ::I18n::Tasks::CommandError, "Add gem 'yandex-translator' to your Gemfile to use this command" | ||
end | ||
super | ||
end | ||
|
||
protected | ||
|
||
def translate_values(list, **options) | ||
list.map { |item| translator.translate(item, options) } | ||
end | ||
|
||
def options_for_translate_values(from:, to:, **options) | ||
options.merge( | ||
from: to_yandex_compatible_locale(from), | ||
to: to_yandex_compatible_locale(to) | ||
) | ||
end | ||
|
||
def options_for_html | ||
{ format: 'html' } | ||
end | ||
|
||
def options_for_plain | ||
{ format: 'plain' } | ||
end | ||
|
||
def no_results_error_message | ||
I18n.t('i18n_tasks.yandex_translate.errors.no_results') | ||
end | ||
|
||
private | ||
|
||
# Convert 'es-ES' to 'es' | ||
def to_yandex_compatible_locale(locale) | ||
return locale unless locale.include?('-') | ||
locale.split('-', 2).first | ||
end | ||
|
||
def translator | ||
@translator ||= Yandex::Translator.new(api_key) | ||
end | ||
|
||
def api_key | ||
@api_key ||= begin | ||
key = @i18n_tasks.translation_config[:yandex_api_key] | ||
fail ::I18n::Tasks::CommandError, I18n.t('i18n_tasks.yandex_translate.errors.no_api_key') if key.blank? | ||
key | ||
end | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This is going to cause lots of requests to the Yandex API, processed in-sequence (slow).
It would be better to pass multiple
text
parameters to the request, batched to avoid hitting the 10,000 character limit, each batch in its own Thread or Fiber. This should be implemented in the yandex gem.This is not a blocker for submitting this PR (just waiting for a new release of the yandex gem).