Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n-tasks reads configuration too late for custom commands #153

Closed
halostatue opened this issue Jun 8, 2015 · 1 comment
Closed

i18n-tasks reads configuration too late for custom commands #153

halostatue opened this issue Jun 8, 2015 · 1 comment
Labels
bug
Milestone
v0.8.5

Comments

@halostatue
Copy link

The wiki has a page for CSV import/export tasks that does not work with 0.8.3 because running i18n-tasks does not load the configuration (config/i18n-tasks.yml.erb) early enough to register the custom commands. Only after a command has been specified is the configuration loaded.

It feels like a proper plug-in system (like the simple ones that Minitest or Hoe implement) would be better so that a CSV task can be added by simple discovery of a gem, but an alternative is to look for a .i18n-tasks.rb file that can be loaded, rather than looking in the config file.
glebm added a commit that referenced this issue Jun 28, 2015
@glebm
Fix plugins support #153
1fe7a44
@glebm glebm added this to the v0.8.5 milestone Jun 28, 2015
@glebm
Copy link
Owner

glebm commented Jun 28, 2015

Hi, thanks for reporting this, should be fixed in v0.8.5. I've had a look at Minitest and I prefer this explicit approach over what minitest does (Gem.find_files("minitest/*_plugin.rb")).

@glebm glebm closed this as completed Jun 28, 2015
@glebm glebm added bug and removed enhancement labels Jun 28, 2015
bartimaeus added a commit to bartimaeus/i18n-tasks that referenced this issue Jun 29, 2015
@bartimaeus
Merge remote-tracking branch 'upstream/master'
80bfe1a 
* upstream/master:
  add app/mailers to default search.relative_roots
  Bump to 0.8.5
  Fix plugins support glebm#153
  changelog
  Bump to 0.8.4
  Lock terminal-table to 1.4.5 due to tj/terminal-table#55
  changelog
  Use ActiveSupport::Inflector.constantize instead of const_get for ruby 1.9 support
  Reduce ActiveSupport dependencies, compat with 2.3
  Support ActionMailer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.8.5
Development

No branches or pull requests
2 participants
@halostatue @glebm