Change constructor tracking to not use type #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added a commit
to the-mikedavis/helix
that referenced
this pull request
May 24, 2022
With respect to the queries: The locals scope for functions was not large enough, so a function's parameter could outlive the function body. To fix it, we just widen the scope to the `function` node. See also gleam-lang/tree-sitter-gleam#25 With respect to the parser: An external scanner has been added that fixes the parsing of strings. Previously, a comment inside a string would act like a comment rather than string contents. See also gleam-lang/tree-sitter-gleam#14 (comment) A new constructor node has been added as well which makes type highlighting more fine grained. See also gleam-lang/tree-sitter-gleam#29
archseer
pushed a commit
to helix-editor/helix
that referenced
this pull request
May 25, 2022
With respect to the queries: The locals scope for functions was not large enough, so a function's parameter could outlive the function body. To fix it, we just widen the scope to the `function` node. See also gleam-lang/tree-sitter-gleam#25 With respect to the parser: An external scanner has been added that fixes the parsing of strings. Previously, a comment inside a string would act like a comment rather than string contents. See also gleam-lang/tree-sitter-gleam#14 (comment) A new constructor node has been added as well which makes type highlighting more fine grained. See also gleam-lang/tree-sitter-gleam#29
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 15, 2022
With respect to the queries: The locals scope for functions was not large enough, so a function's parameter could outlive the function body. To fix it, we just widen the scope to the `function` node. See also gleam-lang/tree-sitter-gleam#25 With respect to the parser: An external scanner has been added that fixes the parsing of strings. Previously, a comment inside a string would act like a comment rather than string contents. See also gleam-lang/tree-sitter-gleam#14 (comment) A new constructor node has been added as well which makes type highlighting more fine grained. See also gleam-lang/tree-sitter-gleam#29
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 15, 2022
With respect to the queries: The locals scope for functions was not large enough, so a function's parameter could outlive the function body. To fix it, we just widen the scope to the `function` node. See also gleam-lang/tree-sitter-gleam#25 With respect to the parser: An external scanner has been added that fixes the parsing of strings. Previously, a comment inside a string would act like a comment rather than string contents. See also gleam-lang/tree-sitter-gleam#14 (comment) A new constructor node has been added as well which makes type highlighting more fine grained. See also gleam-lang/tree-sitter-gleam#29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the tags queries, it seemed odd that we were using
definition.typeandreference.typefor tracking constructors. However, none of the standard set of capture names seem applicable (maybeclass?), so I made upconstructorand hope that most systems don't hardcode the standard set.