-
-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds deps why
functionality
#3408
Conversation
I think this is implementing something slightly different, what we want is given one of the package's direct dependencies a list of all the constraints introduced by the other packages that lead to picking a given version. For example:
But I might have interpreted the issue wrong, it's better to wait for Louis here :) |
Ah, my bad. That makes sense. Once Louis confirms, I will close this PR and try implementing the behavior you mentioned. |
That's right! The output should show all the ways that a package is added to the project. Perhaps something along the lines of
Showing the constraints would be fab here |
Apologies. Thank you for details, @lpil. I will give this a try. |
Maybe it could be a |
@lpil Like Regarding Both |
Maybe just
No I don't think this information should be in the manifest. Neither npm or Cargo store this information in the lock either. Perhaps just having the versions and not the constraints would be a good place to start |
@lpil @giacomocavalieri I finally had some time to take another stab at this. I have an implementation that works like this:
This is more inline with how Cargo works. Is this something we are still interested in? I wanted to check before I create a PR. |
Looks great!! |
Addresses #3267
For ex: Running this on the
test/project_erlang
project returns the following output:This is my first PR for this project. I appreciate any feedback to improve this.