chore: remove solano CI

gkampitakis · Oct 30, 2023 · f3e36ee · f3e36ee
1 parent ae3dc7e
commit f3e36ee
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 46 deletions.
diff --git a/README.md b/README.md
@@ -104,7 +104,6 @@ Officially supported CI servers:
 | [Screwdriver](https://screwdriver.cd/)                                          | `ciinfo.SCREWDRIVER`        | ✅   |
 | [Semaphore](https://semaphoreci.com)                                            | `ciinfo.SEMAPHORE`          | ✅   |
 | [Sourcehut](https://sourcehut.org/)                                             | `ciinfo.SOURCEHUT`          | 🚫   |
-| [Solano CI](https://www.solanolabs.com/)                                        | `ciinfo.SOLANO`             | ✅   |
 | [Strider CD](https://strider-cd.github.io/)                                     | `ciinfo.STRIDER`            | 🚫   |
 | [TaskCluster](http://docs.taskcluster.net)                                      | `ciinfo.TASKCLUSTER`        | 🚫   |
 | [TeamCity](https://www.jetbrains.com/teamcity/) by JetBrains                    | `ciinfo.TEAMCITY`           | 🚫   |
@@ -149,8 +148,3 @@ the given CI server, otherwise `false`.
 
 Examples of vendor constants are `ciinfo.TRAVIS` or `ciinfo.APPVEYOR`. For a
 complete list, see the support table above.
-
-Deprecated vendor constants that will be removed in the next major
-release:
-
-- `ciinfo.IsVendor("TDDIUM")` (Solano CI) This has been renamed `ciinfo.IsVendor("SOLANO")`
diff --git a/ciinfo_test.go b/ciinfo_test.go
@@ -29,9 +29,6 @@ func assertVendorConstants(t *testing.T, expected string) {
 
 	for _, vendor := range vendors {
 		boolean := vendor.constant == expected
-		boolean = expected == "SOLANO" && vendor.constant == "TDDIUM" ||
-			boolean // support deprecated option
-
 		assertEqual(t, boolean, vendorsIsCI[vendor.constant], "ci."+vendor.constant)
 	}
 }
@@ -53,7 +50,7 @@ func TestCI(t *testing.T) {
 
 		initialize()
 
-		assertEqual(t, 49, len(vendors), "We should have 49 vendors")
+		assertEqual(t, 48, len(vendors), "We should have 48 vendors")
 		assertEqual(t, true, IsCI)
 		assertEqual(t, isActualPr(), IsPr)
 		assertEqual(t, "GitHub Actions", Name)
@@ -466,29 +463,6 @@ func TestCI(t *testing.T) {
 				t.Setenv("SEMAPHORE", "true")
 			},
 		},
-		{
-			description: "Solano CI - PR",
-			expected: ScenarioExpected{
-				isPR:     true,
-				name:     "Solano CI",
-				constant: "SOLANO",
-			},
-			setup: func(t *testing.T) {
-				t.Setenv("TDDIUM", "true")
-				t.Setenv("TDDIUM_PR_ID", "42")
-			},
-		},
-		{
-			description: "Solano CI - Not PR",
-			expected: ScenarioExpected{
-				isPR:     false,
-				name:     "Solano CI",
-				constant: "SOLANO",
-			},
-			setup: func(t *testing.T) {
-				t.Setenv("TDDIUM", "true")
-			},
-		},
 		{
 			description: "Sourcehut",
 			expected: ScenarioExpected{

diff --git a/constants.go b/constants.go
@@ -113,9 +113,6 @@ var SCREWDRIVER = vendorsIsCI["SCREWDRIVER"]
 // CI is running on Semaphore
 var SEMAPHORE = vendorsIsCI["SEMAPHORE"]
 
-// CI is running on Solano CI
-var SOLANO = vendorsIsCI["SOLANO"]
-
 // CI is running on Sourcehut
 var SOURCEHUT = vendorsIsCI["SOURCEHUT"]
 

diff --git a/vendors.go b/vendors.go
@@ -310,16 +310,6 @@ var vendors = []vendor{
 			},
 		},
 	},
-	{
-		name:     "Solano CI",
-		constant: "SOLANO",
-		env:      []env{{key: "TDDIUM"}},
-		pr: []pr{
-			{
-				key: "TDDIUM_PR_ID",
-			},
-		},
-	},
 	{
 		name:     "Sourcehut",
 		constant: "SOURCEHUT",