Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct gir paths for NixOS #107

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

samdroid-apps
Copy link
Contributor

Problem: running the CLI would error on NixOS as it does not have /usr/share:

$ yarn build; and yarn ts-for-gir generate
ERROR: No module found in /usr/share/gir-1.0!
Please make sure that you have installed the necessary gir files.
For example with "sudo apt install libgtk-3-dev" for Gtk3 on Ubuntu or "sudo dnf install gtk3-devel" on Fedora. []

Solution: use XDG_DATA_DIRS as commented in code. I think this is harmless on other distros.

@JumpLink
Copy link
Collaborator

JumpLink commented Mar 8, 2023

@samdroid-apps thanks you!
When the CI has finished without errors, I will merge your changes

@JumpLink
Copy link
Collaborator

JumpLink commented Mar 8, 2023

Okay the errors in the CI do not seem to be related to your changes, so I will merge it despite errors 👍

@JumpLink JumpLink merged commit 4e643fd into gjsify:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants