Upgrade gir dependencies to v4 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swsnr
approved these changes
Apr 6, 2024
|
@swsnr Thank you for review, does this mean that you think that this can already be merged and we should continue with the beta types? |
|
I'd go ahead and merge it; after all this repo here has a beta tag on it's versions just as well 🙂 |
|
I'll agree too, I only looked slightly into the types, but it seems good, and local tests showed no regressions (for me) |
Totto16
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have released the first beta of ts-for-gir v4, this version is the result of the fusion of ts-for-gir and gi.ts 🧡
ℹ️ This branch can already be tested as the types are released on npm under the next tag
Changes