Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add js helper methods #159

Merged
merged 39 commits into from
May 16, 2024
Merged

Feature/add js helper methods #159

merged 39 commits into from
May 16, 2024

Conversation

AndreaDotDev
Copy link
Contributor

No description provided.

@AndreaDotDev
Added sendKeys and clear methods to Js class
9a3bf80
@AndreaDotDev
Added getRect, getSize, getTagName methods to Js class
f1f155a
@AndreaDotDev
Better descriptions for Js class methods
825a27f
@AndreaDotDev
Added submit and getLocation methods for Js class; removed KeyPresses…
17345ad 
…Page
@AndreaDotDev
Added getDomAttribute method to js class
a3fbbc8
@AndreaDotDev
Added getDomProperty and getAttribute methods to js class
386641f
@AndreaDotDev
Updated test methods
e061add
@AndreaDotDev
Added StringUtils unit test
99c455c
@AndreaDotDev
Added isSelected, isEnabled and isDisplayed methods to Js class
9b27fe8
@AndreaDotDev
Added part of the unit tests for Js Class
f317e5e
@AndreaDotDev
Added Js getCssValue method and test
0331e5f
@AndreaDotDev
Added JsMethodsUtils and unit tests
a52657e
@AndreaDotDev
Added getShadowRoot method to Js class
724c145
@AndreaDotDev
Formatted code in Js class
7c54aa9
@AndreaDotDev
Added getText method to js class
5ee74c7
@AndreaDotDev
WIP - added findElement method to Js class
be542c1
@AndreaDotDev
WIP - used method overloading for findElement method
448a9cf
@AndreaDotDev
WIP - added xpath Locator for findElement method
597d161
@AndreaDotDev
added findElement method to Js class
879f43c
@AndreaDotDev
Refactoring of variable name
80bb009
@AndreaDotDev
Refactoring of StringUtils to JsStringUtils
e47410e
@AndreaDotDev
Refactoring of code and added test case
e20705c
@AndreaDotDev
WIP - findElements method for Js class
8fe0192
@AndreaDotDev
WIP - refactored JsMethodsUtils
6326ffb
@AndreaDotDev
WIP - added findElements to Js class (to be tested)
c06d7b5
@AndreaDotDev
added findElements method to Js class
016078d
@AndreaDotDev
added Unit tests for JsMethodUtils
e611aa2
@AndreaDotDev
added Unit tests for findElement and findElements methods
8d8eb90
@AndreaDotDev
added all Unit tests for Js class
8b38f44
@giulong giulong self-assigned this May 12, 2024
@giulong giulong self-requested a review May 12, 2024 16:36
@giulong giulong linked an issue May 12, 2024 that may be closed by this pull request
Add Javascript helper methods #138
Closed
giulong
giulong requested changes May 12, 2024
View reviewed changes
Copy link
Owner

@giulong giulong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a first review of the source code, ignoring unit tests for now. Let's focus on implementation: you can @Disable broken tests for the time being.
Some tasks are just cosmetics. Please let me know if there's something unclear.

it/src/test/java/io/github/giulong/spectrum/it/pages/LandingPage.java Outdated Show resolved Hide resolved
it/src/test/java/io/github/giulong/spectrum/it/tests/JavascriptIT.java Outdated Show resolved Hide resolved
spectrum/src/main/java/io/github/giulong/spectrum/enums/LocatorType.java Outdated Show resolved Hide resolved
spectrum/src/main/java/io/github/giulong/spectrum/utils/Js.java Outdated Show resolved Hide resolved
spectrum/src/main/java/io/github/giulong/spectrum/utils/Js.java Outdated Show resolved Hide resolved
spectrum/src/main/java/io/github/giulong/spectrum/utils/JsMethodsUtils.java Outdated Show resolved Hide resolved
spectrum/src/main/java/io/github/giulong/spectrum/utils/JsMethodsUtils.java Outdated Show resolved Hide resolved
spectrum/src/main/java/io/github/giulong/spectrum/utils/JsMethodsUtils.java Outdated Show resolved Hide resolved
spectrum/src/main/java/io/github/giulong/spectrum/utils/JsMethodsUtils.java Outdated Show resolved Hide resolved
spectrum/src/main/java/io/github/giulong/spectrum/enums/LocatorType.java Outdated Show resolved Hide resolved
giulong
giulong requested changes May 14, 2024
View reviewed changes
Copy link
Owner

@giulong giulong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're definitely close to a clean solution. Just few more changes needed 💪

spectrum/src/main/java/io/github/giulong/spectrum/utils/Js.java Outdated Show resolved Hide resolved
spectrum/src/main/java/io/github/giulong/spectrum/utils/Js.java Outdated Show resolved Hide resolved
spectrum/src/main/java/io/github/giulong/spectrum/enums/LocatorType.java Outdated Show resolved Hide resolved
spectrum/src/main/java/io/github/giulong/spectrum/interfaces/WebElementFinder.java Show resolved Hide resolved
spectrum/src/main/java/io/github/giulong/spectrum/enums/LocatorType.java Show resolved Hide resolved
giulong
giulong approved these changes May 16, 2024
View reviewed changes
Copy link
Owner

@giulong giulong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's fine and clean now, good job! Thanks again for contributing 🙏

@giulong giulong merged commit 9f87b9e into giulong:develop May 16, 2024
1 check passed
@giulong
Copy link
Owner

giulong commented May 16, 2024

I'm gonna prepare a new release in the next days with this feature as well. Will tag you there. Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giulong giulong giulong approved these changes

Assignees

@giulong giulong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Javascript helper methods
2 participants
@AndreaDotDev @giulong