Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Add use_selection_fg flag to control selection foreground color #2515

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Upsylonbare
Copy link

When set to False (default True), keep the foreground color of the selected object (commit hash, date, etc ...).

It changes the following:

  • Added a new use_selection_fg flag to the Theme struct, allowing users to toggle whether the selection foreground color is applied.
  • Set use_selection_fg to true by default in Theme::Default.
  • Extended unit tests to validate the behavior of use_selection_fg.

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

When set to `False` (default `True`), keep the foreground color of the selected object (commit hash, date, etc ...).
@extrawurst
Copy link
Collaborator

@Upsylonbare can you elaborate on what the motivation for this change is? Maybe a screenshot of the old vs. new. to help illustrate the issue you try to solve

@Upsylonbare
Copy link
Author

Sure, with default selection_bg (Blue):

here is the before :
image

and after : (with use_selection_fg to false)
image

When using darker selection_bg, this is more useful
Without
image

With:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants