Fixes #3568: Sets input field value when repository path is updated. #3583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there! We would appreciate if you could provide us more information about what you're trying to accomplish here! |
mittalyashu
requested changes
Oct 14, 2019
| @@ -86,6 +87,8 @@ export default { | |||
| methods: { | |||
| fileSectorInput(event) { | |||
| this.pathToRepository = event.target.files[0].path.split("\\").join("/"); | |||
| var repositoryPathInput = document.getElementById("pathToRepository"); | |||
There was a problem hiding this comment.
Can you try doing it with refs?
There was a problem hiding this comment.
I tried using refs first but that didn't fix the issue. I added a ref="repositoryPath" to the inputText element and then put the following code in the fileSectorInput method:
this.$refs.repositoryPath.value = this.pathToRepository;
Do you have any suggestions as to why using the refs didn't work?
Thanks.
There was a problem hiding this comment.
Let me take a look into that.
|
@hansal7014 May I know which OS did you used while working on this PR? |
|
I am getting this error on testing it on MacOS 10.15.2 (not sure if this problem is OS specific).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are being made? (feature/bug)
Fixes a bug where the selected repository path is not showing in the input field if the user edits the field.
Why are these changes necessary? Link any related issues
Fixes bug as requested in issue #3583
Unit Test