Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move test and avoid packaging them #1028

Merged
merged 4 commits into from
Jul 12, 2020
Merged

move test and avoid packaging them #1028

merged 4 commits into from
Jul 12, 2020

Conversation

priv-kweihmann
Copy link
Contributor

Move test files out of git module and into the root dir.
This enables it to ignore them while setuptools packaging and is resulting in a way smaller release package.

Closes #1027

This should ensure that tests are NOT packaged into
release package by setuptools, as tests are development
only
+ fixtures after moving

Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
by using exclude feature of find_packages.
Plus remove now obselete package_data setting

Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
and remove all previously used test related settings

Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
@priv-kweihmann priv-kweihmann changed the title move test and avoid packaging thme move test and avoid packaging them Jul 10, 2020
@Byron Byron self-requested a review July 12, 2020 04:07
@Byron Byron merged commit 0238e6c into gitpython-developers:master Jul 12, 2020
@Byron
Copy link
Member

Byron commented Jul 12, 2020

I am absolutely amazed and am super thankful for this PR and the effort that undoubtedly went into it.
It will have a massive impact to everyone, given that GitPython is downloaded a lot!

Will cut a new release right away!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Don't install unittest code by default
2 participants