Skip to content

Commit

Permalink
Merge pull request #1864 from EliahKagan/pip-toml
Browse files Browse the repository at this point in the history
Use upgraded pip in test fixture virtual environment
  • Loading branch information
Byron committed Mar 11, 2024
2 parents d40e7d0 + a262a06 commit 49cb48a
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions test/lib/helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
import logging
import os
import os.path as osp
import subprocess
import sys
import tempfile
import textwrap
import time
Expand Down Expand Up @@ -411,6 +413,13 @@ def __init__(self, env_dir, *, with_pip):
self._env_dir = env_dir
venv.create(self.env_dir, symlinks=True, with_pip=with_pip)

if with_pip:
# The upgrade_deps parameter to venv.create is 3.9+ only, so do it this way.
command = [self.python, "-m", "pip", "install", "--upgrade", "pip"]
if sys.version_info < (3, 12):
command.append("setuptools")
subprocess.check_output(command)

@property
def env_dir(self):
"""The top-level directory of the environment."""
Expand Down

0 comments on commit 49cb48a

Please sign in to comment.