Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rust toolchain environment issue on RustRover #1497

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

axonasif
Copy link
Member

@axonasif axonasif commented Jan 24, 2025

Description

TODO:

  • Check with VSCode
  • Check with RustRover

Related Issue(s)

Fixes #10974

How to test

Documentation

/hold

@axonasif axonasif marked this pull request as ready for review February 5, 2025 01:50
@axonasif axonasif requested review from a team as code owners February 5, 2025 01:50
@axonasif axonasif enabled auto-merge (squash) February 5, 2025 02:11
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @axonasif! Thanks for looking into it

I've followed the specified testing steps and could see the process exiting right away, with no build.
image

@axonasif axonasif merged commit c59b50a into main Feb 5, 2025
4 checks passed
@axonasif axonasif deleted the axonasif/fix_rr_rust branch February 5, 2025 09:28
@axonasif
Copy link
Member Author

axonasif commented Feb 7, 2025

Hey @filiptronicek, that error is expected and is related with the project itself. Sorry for not mentioning in the PR body.

@filiptronicek
Copy link
Member

@axonasif no worries! It was my first assumption that something is broken with the project, so we're all good here

@axonasif
Copy link
Member Author

axonasif commented Feb 7, 2025

🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants