Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prebuilds] Increase timeout and/or make it configurable #6283

Closed
mikenikles opened this issue Oct 19, 2021 · 11 comments
Closed

[Prebuilds] Increase timeout and/or make it configurable #6283

mikenikles opened this issue Oct 19, 2021 · 11 comments
Labels
feature: prebuilds meta: stale This issue/PR is stale and will be closed soon type: feature request New feature or request

Comments

@mikenikles
Copy link
Contributor

The current prebuild timeout is set to 1h. I'm working with some large projects that require more time to compile everything, up to 3 hours given current estimates.

Related to this, it would be a good user experience to allow a configurable timeout per project.

@gtsiolis
Copy link
Contributor

FYI, This is also cross-linked[1] in the docs. 🎗️

@Trott
Copy link

Trott commented Oct 23, 2021

If it's useful info, I just built Node.js on a Gitpod workspace and it took 83 minutes. So, uh, being able to set it to around 90 minutes or so would let me do Node.js prebuilds, which would be incredibly useful to me.

@tobiasdiez
Copy link

Is there a ETA for when the build times is increased? For https://github.com/sagemath/sage we are currently also above the 1h mark.

@georg480
Copy link

My prebuild is aborted after one hour, is there a parameter with which I can change the time? The option (Incremental Prebuilds
Enable Incremental Prebuilds Beta) for is also active.

@Trott
Copy link

Trott commented Dec 25, 2021

is there a parameter with which I can change the time?

As far as I know, the answer is still "no" but I want to share a workaround I've done that has helped me out a lot.

Here's the GitPod YAML config for one of my projects:

tasks:
  - init: ./configure && timeout 45m make -j16 || true

The timeout 45m make -j16 || true cause make -j16 to run for 45 minutes. After that, it is terminated but the || true causes a success status code to be provided rather than a failure status code. Since my builds take more than an hour, but usually less than an hour and 15 minutes, that gives me a very big head start on my builds when I open the workspace. This depends on having a build step that can pick up where it left off rather than needing to start over.

@stale
Copy link

stale bot commented Mar 26, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Mar 26, 2022
@tobiasdiez
Copy link

Prebuild still timeout after 1h.

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Mar 27, 2022
havogt added a commit to havogt/llvm-project that referenced this issue May 18, 2022
@stale
Copy link

stale bot commented Jun 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jun 27, 2022
@rober-m
Copy link

rober-m commented Jun 28, 2022

Please, add configurable timeout for projects that take longer than 1h! 🙏

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Jun 28, 2022
@svenefftinge
Copy link
Member

Adding the possibility for configurable timeouts makes a lot of sense for usage-based plans (to be released soon).

@stale
Copy link

stale bot commented Nov 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Nov 9, 2022
@stale stale bot closed this as completed Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: prebuilds meta: stale This issue/PR is stale and will be closed soon type: feature request New feature or request
Projects
Status: In Validation
Development

No branches or pull requests

7 participants