refactor: layout components #1868
Merged
+1,741
−378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
setchy
commented
Feb 27, 2025
| @@ -20,7 +20,7 @@ export const Checkbox: FC<ICheckbox> = ({ | |||
| visible = true, | |||
| ...props | |||
| }: ICheckbox) => { | |||
| const counter = props.counter > 0 ? props.counter : undefined; | |||
| const counter = props?.counter === 0 ? '0' : props.counter; | |||
There was a problem hiding this comment.
When 0 is left as a number, it will not be rendered within the counter label correctly
There was a problem hiding this comment.
Sounds painful to figure out.
Worth leaving this as a code comment?
setchy
commented
Feb 27, 2025
| * similar to CounterLabel from @primer/react but with customizable styling. | ||
| * | ||
| * Created due to odd behavior with CounterLabel: | ||
| * - would show screen vertical scrollbar which is undesirable. |
There was a problem hiding this comment.
literally hours to figure this out 😭
setchy
commented
Feb 27, 2025
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor some layout components
And importantly, fix our vertical scrollbar regression on Filters, caused by the primer CounterLabel component, which only occurred in certain states. tldr; that took hours to triage and find. 😅. Solution was to create a custom component which solved a few other gaps. Left some comments for future maintainers/contributors to understand "why".