Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist the HideSingleWidgetTitleBar and AllowedAreas state #235

Conversation

SleepProgger
Copy link

@SleepProgger SleepProgger commented Aug 8, 2020

Currently the HideSingleWidgetTitleBar and AllowedAreas state of Areas is lost on loading the state.
This PR fixes this.
Should be backwards compatible without a problem.

I also smuggled in a getter for HideSingleWidgetTitleBar which i missed previously.

@githubuser0xFFFF
Copy link
Owner

Thank you for the pull request. I'm on vacation at the moment and will review your patch when I'm back next week.

@githubuser0xFFFF
Copy link
Owner

I implemented your pull request with some changes. I changed the following:

  • HideSingleWidgetTitleBar is now a flag of CDockArea
  • the allowed areas and flags are only written to XML if they are not the default values to keep the XML output small

The functionality is now in master. Please test.

@SleepProgger
Copy link
Author

Yup seem to be fine. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants